SFTtech/openage

Allow easy usage of different compiler versions in the buildsystem

Closed

#1,253 opened on May 4, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (1,135 forks)batch import
area: buildsystemgood first issueimprovement

Repository metrics

Stars
 (12,130 stars)
PR merge metrics
 (Avg merge 9d 23h) (1 merged PR in 30d)

Description

Right now we can not easily set a compile and a version within our configure script. #1250 did a small fix for clang-9 and clang-10 because we needed that for the CI. But it would be nice to create some parser that "respects the versions making it easier to test for multiple compiler versions" (@TheJJ ).

Regarding:

This should be just a small fix, we should probably implement something that splits compiler into compiler-name and compiler-version => if it's clang and then append the version to clang++.

Originally posted by @simonsan in https://github.com/SFTtech/openage/pull/1250

And yes, the compiler-name-and-version parser would be the real fix. But, if we implement it, the version should actually be respected, since that way you may test multiple compiler versions easily.

Originally posted by @TheJJ in https://github.com/SFTtech/openage/pull/1250

Contributor guide

Research direction
Examine the configure script (likely in the buildsystem directory) and the changes from PR #1250 to understand how compiler versions are currently handled. Implement a parser that splits the compiler string into name and version, then uses the version to select the appropriate compiler binary (e.g., clang++ 10). Ensure the parser respects the version to allow testing multiple compiler versions. Review the discussion in the linked PR for further context.
Tech stack
pythoncpp
Domain
build systemdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python scriptingBuild system knowledgeC++ compiler basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70