Roll20/roll20-character-sheets

[Dark Heresy 2nd Edition] Unnatural Characteristics not being added on successful tests

Closed

#14,138 opened on Jun 21, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)HTML (4,040 forks)batch import
help wanted

Repository metrics

Stars
 (1,120 stars)
PR merge metrics
 (Avg merge 2d 6h) (83 merged PRs in 30d)

Description

If a character sheet has a value in the "Unnatural Characteristic" box (e.g., SC below has a Strength of 25 and Unnatural Strength (1)), half of the Unnatural Characteristic value, rounded up, should be added to Degrees of Success on a success, but only on a success, per rule SC below. Currently, the sheet does not add Unnatural Characteristic values on a successful test. Image

Image

Contributor guide

Research direction
Locate the section of the sheet worker script that handles degree of success calculation for Dark Heresy 2nd Edition. Identify the logic for modifying degrees of success based on traits and add the half (rounded up) of Unnatural Characteristics value when the test is successful. Refer to the official rulebook for the correct formula.
Tech stack
javascripthtml
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60