RicoSuter/NSwag

OperationSecurityScopeProcessor looks at Roles but not Policy in AuthorizeAttribute

Open

#1,674 opened on Oct 18, 2018

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)C# (1,357 forks)batch import
help wantedproject: NSwag.SwaggerGenerationtype: enhancement

Repository metrics

Stars
 (7,359 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

OperationSecurityScopeProcessor looks at Roles of an AuthorizeAttribute but ignores it if there are no roles given. It does not work if the AuthorizeAttribute has a Policy property but no Roles.

How does this work with https://docs.microsoft.com/en-us/aspnet/core/security/authorization/policies?view=aspnetcore-2.1?

Contributor guide

Research direction
Inspect OperationSecurityScopeProcessor.cs, specifically the logic that reads AuthorizeAttribute.Roles, and extend it to also check the Policy property. Research ASP.NET Core authorization policies to understand how to map policies to OpenAPI security scopes.
Tech stack
csharp
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75