ReactiveX/rxjs

WebSocketSubject may have different input and output types.

Open

#5,381 opened on Apr 6, 2020

View on GitHubContributor guide
 (2 comments) (2 reactions) (0 assignees)TypeScript (2,990 forks)batch import
bughelp wanted

Repository metrics

Stars
 (31,707 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Just what the title says... The AnonymousSubject (aka "frankensubject") probably also needs some typings love.

Basically, a nicer interface would be:

class WebSocketSubject<In, Out> extends Observable<Out> implements Observer<In> {
  // ...stuff
}

Contributor guide

Research direction
Examine the current WebSocketSubject and AnonymousSubject type definitions to understand how they are used. Propose a change to add separate generic parameters for input and output types, ensuring backward compatibility.
Tech stack
typescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptRxJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65