ReactiveX/rxjs

Rename window to windowWith

Open

#5,296 opened on Feb 6, 2020

View on GitHubContributor guide
 (6 comments) (0 reactions) (1 assignee)TypeScript (2,990 forks)batch import
help wanted

Repository metrics

Stars
 (31,707 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

We need to deprecate window, because it was a really dumb name, and rename it to windowWith or the like. I suggest windowWith just out of the spirit of concatWith and mergeWith renames... But I'm open to suggestions.

Related: https://github.com/ReactiveX/rxjs/issues/3788

Contributor guide

Research direction
Implement the rename of `window` to `windowWith` and add a deprecation warning for `window`.
Tech stack
typescript
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptRxJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70