QAC-Portal/QA-Portal

QA_Logo.png is referenced absolutely in target/classes folder

Open

#9 opened on Dec 2, 2019

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Java (5 forks)auto 404
APIenhancementgood first issue

Repository metrics

Stars
 (2 stars)
PR merge metrics
 (PR metrics pending)

Description

Description

SHOULD BE ADDRESSED BEFORE DEPLOYMENT TO TEST OR PRODUCTION

The CvPdfEnums class in cv-api project has a hard coded reference to \target\classes folder. Should be amended so that the location of the file being referenced is defined in a property in the application.yml file.

Task Description

QA_Logo.png is referenced explicitly in target/classes folder in CvPdfEnums.

Add a property to the application.yml file for cv-api project to define the location of the file and amend CvPdfEnums to get the file location from this property rather than using a hard coded value.

Contributor guide

Research direction
Add a new property in application.yml for the logo path (e.g., logo.path=classpath:static/QA Logo.png). Then in CvPdfEnums, inject the property using @Value and use it instead of the hardcoded path.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaSpring Boot
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70