QAC-Portal/QA-Portal

Slightly Refactor Skills - CV api

Open

#183 opened on Dec 18, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (5 forks)auto 404
Low PriorityUIgood first issuejava

Repository metrics

Stars
 (2 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently in the CV api, under CvVersion.java, a person's skills are initialised as type List<Skills>.

However, Skills itself is an object made up of a list of skills. It's my understanding that everything can actually be contained within one Skills object, rather than a list of them (a list of lists).

This issue would involve:

  • changing the allSkills variable in CvVersion to be of type Skills rather than List<Skills>

  • making sure nothing breaks in the process

  • rewriting the few CV api tests that refer to the allSkills variable

Contributor guide

Research direction
Locate CvVersion.java in the CV API, change the type of allSkills from List<Skills> to Skills, update all test files that reference allSkills, and run the test suite to verify nothing breaks.
Tech stack
java
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85