QAC-Portal/QA-Portal

Change cv-api test config

Open

#174 opened on Dec 16, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (5 forks)auto 404
Low PriorityTestinggood first issuejava

Repository metrics

Stars
 (2 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently, tests for cv-api rely on their own config file, cv-api/src/test/resources/application.yml.

This is necessary for line #35: enable_public_endpoints: true

This overrides development's default application.yml file, where this value is set to false, and is necessary for smoke testing the PublicCvManagementController.

However as seen by #173, this causes issue every time the cv-api config is changed.

Rather than duplicate all changes to the main config file in the test package's config file, a better solution might be to implement Spring Boot's @ActiveProfiles annotation, which allows the tests to load their own altered version of application.yml.

Contributor guide

Research direction
Implement @ActiveProfiles annotation on the test class and create a separate application test.yml with only the overridden property. Alternatively, use @TestPropertySource to set the property directly. Remove the duplicated config file in src/test/resources.
Tech stack
javaspring
Domain
backendtesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaSpring
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70