PostHog/posthog

Add pageleave warning to Feature Flags edit page if changes are not committed

Closed

#5,187 opened on Jul 17, 2021

View on GitHubContributor guide
 (19 comments) (0 reactions) (1 assignee)Python (988 forks)batch import
enhancementfeature/feature-flagsgood first issueteam/feature-flags

Repository metrics

Stars
 (16,704 stars)
PR merge metrics
 (Avg merge 17h 29m) (995 merged PRs in 30d)

Description

Is your feature request related to a problem?

It is way too easy to navigate away from the Feature Flags edit page without pressing "Save", losing all changes. I have done it probably a dozen times.

Describe the solution you'd like

Longer term, any changes to filter criteria should auto-save. But because this will probably require extra testing and implementation time, for now a browser message like "Are you sure? Changes may not be saved" would suffice.

Describe alternatives you've considered

Additional context

Thank you for your feature request – we love each and every one!

Contributor guide

Research direction
Look at the Feature Flags edit page component (likely in frontend/src/scenes/FeatureFlags/FeatureFlagsEdit.tsx). Add a beforeunload event listener that triggers when there are unsaved changes. Ensure the warning only shows when form is dirty. Review existing patterns for unsaved changes warnings in other edit pages in the codebase for consistency.
Tech stack
typescriptreactcss
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScriptPostHog frontend conventionsbrowser event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75