PSPDFKit-labs/bypass

Multiple expect_once

Open

#95 opened on May 10, 2020

View on GitHub
 (4 comments) (13 reactions) (0 assignees)Elixir (89 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (847 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

@ream88 any possibility of making it so that within one test I can stack two expect_once's so that the first call to the given route gets my first expect_once and the second call gets the second expect_once? Currently the second expect_once would just redefine the first expect_once and I would get an error because the route is called twice.

Originally posted by @agramichael in https://github.com/PSPDFKit-labs/bypass/issues/88#issuecomment-618452699

Contributor guide

Research direction
Examine the implementation of expect once in Bypass, particularly how it sets a single expectation per route. Modify it to store a list of expectations and process them in order on each request. Update existing tests and add new ones to verify multiple expect once calls work as intended.
Tech stack
elixir
Domain
backendtesting
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ElixirGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75