PSPDFKit-labs/bypass

Route error on valid routes

Open

#76 opened on Jan 17, 2019

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Elixir (89 forks)batch import
help wanted

Repository metrics

Stars
 (847 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi,

I get an Route error on routes with decimal values like /myroute/v1/0,10.0

Request: GET /myroute/v1/0,10.0
** (exit) an exception was raised:
    ** (RuntimeError) Route error
        (bypass) lib/bypass/plug.ex:24: Bypass.Plug.call/2
        (plug_cowboy) lib/plug/cowboy/handler.ex:12: Plug.Cowboy.Handler.init/2
        (cowboy) myroute/deps/cowboy/src/cowboy_handler.erl:41: :cowboy_handler.execute/2
        (cowboy) myroute/deps/cowboy/src/cowboy_stream_h.erl:296: :cowboy_stream_h.execute/3
        (cowboy) myroute/deps/cowboy/src/cowboy_stream_h.erl:274: :cowboy_stream_h.request_process/3
        (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3

OWM use these routes example here https://samples.openweathermap.org/pollution/v1/co/0.0,10.0/current.json?appid=b1b15e88fa797225412429c1c50c122a1

I'm not sure if this is a Plug specific issue.

Contributor guide

Research direction
Investigate how Bypass handles route matching with decimal points in the path. Check the Plug router configuration and the Cowboy handler to see if there is a character escaping or routing issue.
Tech stack
elixir
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
ElixirGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40