OpenGenus/cosmos

Swift: fibonnaciMemoized does not memoize

Open

#2,579 opened on Oct 27, 2017

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)C++ (3,724 forks)batch import
Hacktoberfestadd codenew algorithm

Repository metrics

Stars
 (13,462 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This is a(n):

  • New algorithm
  • Update to an existing algorithm
  • Error
  • Proposal to the Repository

Details:

The fibonnaciMemoized() function (code/mathematical-algorithms/fibonacci_number/fibonacci_memorized.swift) does not memoize values cross recursion calls.

Contributor guide

Research direction
Inspect the fibonacciMemoized function in fibonacci memorized.swift. The memoization dictionary is likely defined inside the function, causing it to be recreated on each call. To fix, move the dictionary outside the function or use a static variable to persist across calls.
Tech stack
swift
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75