OpenFeign/feign

MockClient decode url before matching

Open

#787 opened on Sep 13, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (1,911 forks)batch import
bughelp wanted

Repository metrics

Stars
 (9,070 stars)
PR merge metrics
 (Avg merge 3d 8h) (59 merged PRs in 30d)

Description

When executing a request, inside this method public synchronized Response execute(Request request, Request.Options options) requestKey is created based on the request. However, it decodes the url so that we cannot test the actual url will be sent by the client.

For example, if my request url contains %2F like /a%2Fb, the requestKey only contains /. When I expect the final url which is sent to server should be /a%2Fb. What I get from mockClient is a url /a/b

Contributor guide

Research direction
Examine the execute method in MockClient.java to understand how requestKey is generated from the request URL. The issue indicates that URL decoding occurs, so the fix is to either not decode the URL or to preserve the original encoded URL for matching. Review the codebase for any existing URL normalization logic. No linked PRs or comments are available.
Tech stack
java
Domain
testingapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaHTTPUnit testingFeign basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75