OpenChemistry/avogadrolibs

Export to MP4 should test for "avconv" in path

Open

#282 opened on Jun 18, 2018

View on GitHubContributor guide
 (2 comments) (0 reactions) (1 assignee)C++ (232 forks)auto 404
bughacktoberfest

Repository metrics

Stars
 (662 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/OpenChemistry/avogadrolibs/blob/da6ebb9f0e39c73ca861001e390d13e6ed3e6cb5/avogadro/qtplugins/playertool/playertool.cpp#L249

This requires avconv to be installed in the system. If avconv is not installed, this particular snippet still executes, but no mp4 file is saved and there is no warning or error thrown saying that avconv is not found.

https://github.com/OpenChemistry/avogadrolibs/blob/da6ebb9f0e39c73ca861001e390d13e6ed3e6cb5/avogadro/qtplugins/playertool/playertool.cpp#L232 In Windows, the png export itself isn't taking place. avconv execution will also presumably fail I guess. Should we resort to including libraries for these in the build?

Contributor guide

Research direction
Inspect the code around line 249 in avogadro/qtplugins/playertool/playertool.cpp to understand how avconv is invoked. Research how to check if avconv is available on the system (e.g., using QStandardPaths or QProcess to search the PATH). Determine the best way to warn the user or throw an error when avconv is missing, and consider Windows specific differences.
Tech stack
cpp
Domain
desktop devaudio video rtc
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75