NuGet/Home

RestoreLockedMode=true & RestoreForceEvaluate=true should error

Closed

#8,222 opened on Jun 13, 2019

View on GitHubContributor guide
 (6 comments) (1 reaction) (1 assignee)HTML (292 forks)batch import
Area:ErrorHandlingArea:RestoreRepeatableBuildCategory:Quality WeekFunctionality:RestorePriority:2Type:Bughelp wanted

Repository metrics

Stars
 (1,459 stars)
PR merge metrics
 (Avg merge 464d 23h) (1 merged PR in 30d)

Description

Currently that's not the case.

Repro steps

  1. dotnet new classlib
  2. Enable lock file
  3. dotnet restore (generate lock file).
  4. dotnet restore /p:LockedMode="true"
  5. dotnet restore /p:LockedMode="true" /p:RestoreForceEvaluate="true"

The last one should fail, as the instructions do not make sense. From skimming the code, RestoreForceEvaluate takes precedence.

https://github.com/NuGet/NuGet.Client/blob/bdcec93681afdd1f5cd553af07414a3b3d9a866c/src/NuGet.Core/NuGet.Commands/RestoreCommand/RestoreCommand.cs#L462

//cc @anangaur It's a trivial fix, so prioritize if you see a need for it.

Contributor guide

Research direction
Inspect the RestoreCommand.cs file at line 462. Add validation to throw an error when both LockedMode and RestoreForceEvaluate are true.
Tech stack
csharp
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gitdotnet SDK
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90