Mikubill/sd-webui-controlnet

[Bug]: Multi-ControlNet XYZ plot support is broken

Open

#1,271 opened on May 14, 2023

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Python (2,011 forks)batch import
help wanted

Repository metrics

Stars
 (17,851 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits of both this extension and the webui

What happened?

Now the ControlNet XYZ options have force type checking, which brakes the support of list notation style merged in #407

Steps to reproduce the problem

  1. Go to XYZ plot
  2. Select ControlNet Enable
  3. It is forced to enter true or false, not the list notation

What should have happened?

Should be able to enter the list notation

Commit where the problem happens

webui: v1.2.1-3-g6c996583 controlnet: 356fd3c0 (Sun May 14 02:47:11 2023)

What browsers do you use to access the UI ?

Microsoft Edge

Command Line Arguments

--skip-version-check --opt-sdp-attention --api --theme=light

Console logs

No, It's block by the frontend

Additional information

No response

Contributor guide

Research direction
Locate the frontend code that enforces type checking on ControlNet XYZ plot fields and modify it to accept list notation as described in PR #407.
Tech stack
pythonjavascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75