Midburn/spark

Clean global scope in all controllers.

Open

#980 opened on Nov 29, 2018

View on GitHubContributor guide
 (1 comment) (0 reactions) (1 assignee)JavaScript (44 forks)auto 404
Cleanupgood first issue

Repository metrics

Stars
 (18 stars)
PR merge metrics
 (PR metrics pending)

Description

Overview of the problem

We have several functions declared globally in controller files. This can create issues hard to anticipate and solve.

Description

  1. We need to move all functions into scope. image image
  2. We need to make sure the functions aren't used in any other file (if so, we should create an AngularJS service to be shared between the controllers)
  3. Sanity after the cleanup - check most screens and buttons don't raise exceptions related to missing functions.

Expected behavior

Functions should be scoped

Actual behavior

Functions are declared outside of AngularJS's controllers call back

Contributor guide

Research direction
Search for functions declared outside controller callbacks in all controller files, check their usage across the codebase (e.g., using grep or IDE search), then move them into the controller scope or extract into AngularJS services if shared.
Tech stack
javascript
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptAngularJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70