Microsoft/vscode

Git - .gitignore'd files sometimes not greyed-out

Open

#70,963 opened on Mar 22, 2019

View on GitHubContributor guide
 (74 comments) (43 reactions) (1 assignee)TypeScript (39,847 forks)batch import
buggithelp wanted

Repository metrics

Stars
 (184,936 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Hi 👋

Sometimes files and folders that are in .gitignore and normally greyed-out just stop being greyed-out. #70099 may be related, see how in the first image in comment https://github.com/Microsoft/vscode/issues/70099#issuecomment-471596614 node_modules directory is not greyed out, however in the second one it is properly greyed-out again.

Here is a quick gif (I do ⌘⇧P — Reload window in the middle of it):

hello

Unfortunately, cannot reproduce 😞

  • VSCode Version: 1.32.3
  • OS Version: 10.14.3

Contributor guide

Research direction
Investigate the git decoration logic for .gitignore files, focusing on when the decorator fails to apply the greyed out style. Check for race conditions or cache invalidation issues. Monitor the file watcher and git status updates.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50