Microsoft/vscode

[json] add commas automatically

Open

#69,545 opened on Feb 27, 2019

View on GitHubContributor guide
 (12 comments) (26 reactions) (1 assignee)TypeScript (39,847 forks)batch import
feature-requesthelp wantedjson

Repository metrics

Stars
 (184,936 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Test case

untitledb2

Expected behavior

  • After typing age TAB, the comma should be added to the end of the previous line.
  • After typing " for the next object property, the comma should be added to the end of the previous line.

Actual behavior

The autocomplete does not produce valid text.

Discussion

In general, the autocomplete should strive to produce output that is maximally valid in whatever language grammar it is using.

Contributor guide

Research direction
Trace the autocomplete logic for JSON syntax to understand where commas should be inserted automatically.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptVS Code extension development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65