Microsoft/vscode

Git - Gracefully handle git hooks

Open

#64,409 opened on Dec 5, 2018

View on GitHubContributor guide
 (4 comments) (44 reactions) (1 assignee)TypeScript (39,847 forks)batch import
feature-requestgithelp wanted

Repository metrics

Stars
 (184,936 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Most projects will have some form of precommit hooks for linting or tests through libraries such as lint-staged and husky.

When committing via the source control panel in VSCode there's no visual indicator for when a git hook is running. I think this could be an opportunity to put some UI indicator around this.

Contributor guide

Research direction
Investigate the source control UI in VSCode to find where git hooks are run and how to display a progress indicator or notification when a hook is executing. Look at the Git extension's source code in vscode repository for relevant IPC or event handlers.
Tech stack
typescript
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitVSCode extension API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60