Microsoft/vscode

[folding] Move line up/down should skip over folded regions or folded sections

Open

#63,972 opened on Nov 29, 2018

View on GitHubContributor guide
 (14 comments) (76 reactions) (1 assignee)TypeScript (39,847 forks)batch import
editor-commandseditor-foldingfeature-requesthelp wanted

Repository metrics

Stars
 (184,936 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

  • VSCode Version:1.30.0-insider
  • OS Version: windows 10

I think when code is in a folded region or section it should never unfold unless explicitly commanded, so if you are moving a line using move command, the line should skip over both folded regions and folded sections Steps to Reproduce:

  1. create a folded region using #region #endregion
  2. fold some code section
  3. move a line using alt+up/down over the folded region/section vscodemovelinebug

Does this issue occur when all extensions are disabled?: Yes

Contributor guide

Research direction
Investigate the moveLines action in the editor source code (likely in src/vs/editor/contrib/moveLines/). Trace how lines are moved and where folding state is affected. The fix should skip moving into folded regions, i.e., when moving a line up/down over a folded region, the line should jump to the other side without unfolding.
Tech stack
typescript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60