Microsoft/vscode

moving TypeScript files in explorer fails to update/prompt imports when containing folder is moved

Open

#58,987 opened on Sep 19, 2018

View on GitHubContributor guide
 (17 comments) (18 reactions) (1 assignee)TypeScript (39,847 forks)batch import
bughelp wantedtypescript

Repository metrics

Stars
 (184,936 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

  • VSCode Version: 1.27.2
  • OS Version: Win 10
  • Typescript: 3.0.3

Steps to Reproduce:

  1. Set update imports on move typescript setting to prompt
  2. Create an empty project with 2 typescript files, one importing from the other.
  3. In the explorer manually move the depended upon file to a new directory. You will be prompted to update the import. This works fine.
  4. Now move that directory into ANOTHER new directory.
  5. This time there is no prompt and the import will be broken

Contributor guide

Research direction
Investigate the file move event handling in VSCode's explorer and the TypeScript language service integration. Trace the code path when a folder is moved and see why import updates are not triggered for nested moves.
Tech stack
typescript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptVSCode API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50