Microsoft/vscode

Terminal search gives up after only 1000 search highlights

Open

#230,365 opened on Oct 3, 2024

View on GitHubContributor guide
 (4 comments) (0 reactions) (1 assignee)TypeScript (39,847 forks)batch import
bughelp wantedperfterminal-findupstreamupstream-issue-linked

Repository metrics

Stars
 (184,936 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

  • run a script that prints TRIES n
  • search for regex TRIES \d
  • scroll around a little
  • :bug: search matches aren't reliable

Contributor guide

Research direction
Trace the terminal search implementation in VS Code. Look for where search results are capped at 1000 highlights. Examine the code in the terminal search provider to find the limit and understand how to increase or remove it.
Tech stack
typescript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70