Microsoft/vscode

Diff chunks are not optimal

Open

#214,962 opened on Jun 12, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (1 assignee)TypeScript (39,847 forks)batch import
bugdiff-editorhelp wanted

Repository metrics

Stars
 (184,936 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.90.0
  • OS Version: Win 11

Steps to Reproduce:

  1. Monaco Playground

An optimal diff chunk would comprise

if 3:
    pass

image

Contributor guide

Research direction
Inspect the diff algorithm implementation in Monaco Editor (vscode's editor component). Look at the diff chunk generation logic in `src/vs/editor/common/diff/` and trace how line ranges are computed. Compare with the optimal diff shown in the playground example.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScriptKnowledge of diff algorithms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50