Microsoft/vscode

Add "resourceWebviewId" context key for webviews in `editor/title/context` contribution point

Open

#195,960 opened on Oct 19, 2023

View on GitHubContributor guide
 (2 comments) (1 reaction) (1 assignee)TypeScript (39,847 forks)batch import
apifeature-requesthelp wanted

Repository metrics

Stars
 (184,936 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Currently there isn't a context key that allows extensions to properly scope editor/title/context contributions to their specific webview. Today I am using activeWebviewPanelId, but that only works if you right-click on the active tab. If you right-click on an inactive tab, then activeWebviewPanelId will still be the "active" tab and show the wrong items.

Contributor guide

Research direction
Search for the definition of 'activeWebviewPanelId' and 'webviewPanelId' in the VS Code source base (likely in the context key service). Follow the pattern to add a new context key 'resourceWebviewId' that captures the webview panel ID of the tab being right clicked, not just the active one. Trace the context evaluation path for 'editor/title/context' contributions.
Tech stack
typescript
Domain
api
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScriptVS Code extension development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60