Microsoft/react-native-windows

Add Functional Tests for Text Component

Open

#12,464 opened on Nov 29, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (544 forks)batch import
Area: FabricArea: TestsNew ArchitectureWorkstream: Test Coverageenhancementgood first issue

Repository metrics

Stars
 (6,114 stars)
PR merge metrics
 (Avg merge 3d 17h) (62 merged PRs in 30d)

Description

Test cases should be added to the E2E test app (Fabric) to validate the following functionality scenarios.

### Tasks
- [ ] Text should update upon fast refresh.
- [ ] Text font should update upon fast refresh.
- [ ] Text size should update upon fast refresh.
- [ ] Text weight should update upon fast refresh.
- [ ] Text color should update upon fast refresh.
- [ ] Text styling should update upon fast refresh.
- [ ] Text line height should update upon fast refresh.
- [ ] Text alignment should updte upon fast refresh.
- [ ] Text font style should update upon fast refresh.
- [ ] Text background color should update upon fast refresh.
- [ ] Text transform should update upon fast refresh.
- [ ] Text borders should update upon fast refresh.
- [ ] Text foreground should not be overwritten when backgroundColor is set.
- [ ] Updates to a raw text node should not overwrite the TextBlock parent if it has only a single Span child inline. #7572
- [ ] Text should be marked dirty when descendant text nodes are added or removed
- [ ] Text should also be marked dirty when descendants of descendant virtual text nodes have changes to their text content.
- [ ] A raw text update to a non-optimized Text component should not call ClearValue on the TextBlock::TextProperty #11000
- [ ] Changes to the backgroundColor prop on virtual text nodes should update their corresponding TextHighlighters. #8408
- [ ] Changes to the underlying text should update the TextHighlighter ranges #8408
- [ ] Text numberOfLines should update upon fast refresh.
- [ ] Text should trigger action upon press.
- [ ] Text should trigger action upon long press.

Contributor guide

Research direction
Examine the existing E2E test app in the repository, likely under packages/e2e test app, to understand the test structure. Look at similar test files for other components to replicate the pattern. Each task corresponds to a specific assertion about the Text component's behavior upon fast refresh. Implement tests using the same testing framework used in the project. Consult the discussion in issue #12464 for any clarifications.
Tech stack
reactjavascripttypescript
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Familiarity with React NativeKnowledge of E2E testingAbility to run Fabric test app
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80