Microsoft/monaco-editor

Improve Python syntax highlighting

Open

#1,762 opened on Jan 12, 2020

View on GitHubContributor guide
 (7 comments) (3 reactions) (0 assignees)JavaScript (4,064 forks)batch import
feature-requestgrammarshelp wanted

Repository metrics

Stars
 (46,002 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

monaco-editor version: 0.19.2 Browser: Chrome 79 maybe OS: macOS Mojave Playground code that reproduces the issue:

monaco.editor.create(document.getElementById("container"), {
	value: "from functions import sum, average",
	language: "python"
});

Basically some import statements in Python aren't highlighted properly.

How Monaco/Monarch highlights things:

image

How VSCode highlights things:

image

Contributor guide

Research direction
Investigate the Python Monarch tokenizer in monaco editor to find why import statements are not highlighted properly. Compare with VSCode's Python tokenizer and adjust rules accordingly.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Monarch tokenizer knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65