Microsoft/calculator

Update Calculator engine’s use of smart pointers

Open

#61 opened on Feb 27, 2019

View on GitHubContributor guide
 (20 comments) (0 reactions) (0 assignees)C++ (5,745 forks)batch import
Pri: 2approvedcodebase qualityhelp wanted

Repository metrics

Stars
 (30,929 stars)
PR merge metrics
 (Avg merge 15h 43m) (7 merged PRs in 30d)

Description

The Calculator engine allocates and frees its own memory which leads to issues such as double-frees that are hard to investigate. We should clean this code and switch to modern constructs such as smart_ptrs to eliminate these issues.

Contributor guide

Research direction
Identify all raw pointer allocations in the Calculator engine and replace them with appropriate smart pointers (unique ptr, shared ptr, etc.). Ensure no memory leaks or double frees remain.
Tech stack
cpp
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Smart PointersMemory Management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60