Microsoft/TypeScript

DefinitionResponse selects full type range

Open

#8,808 opened on May 25, 2016

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)TypeScript (13,395 forks)batch import
Domain: APIHelp WantedSuggestion

Repository metrics

Stars
 (108,860 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

When sending a definition request to the tsserver, the response contains a range selection of the whole type. For UX proposes it would be better to either select only the identifying portion, like a type name, or additional include such an identifying range.

See https://github.com/Microsoft/vscode/issues/6772 for some background.

Contributor guide

Research direction
Investigate the tsserver definition handler to understand how the range for definition responses is computed, and modify it to include a more precise identifying range (e.g., just the type name) in addition to the full type range.
Tech stack
typescript
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60