Microsoft/TypeScript

Number.prototype.toFixed, Number.prototype.toExponential,Number.prototype.toPrecision comments error

Closed

#59,653 opened on Aug 16, 2024

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)TypeScript (13,395 forks)batch import
BugDomain: lib.d.tsHelp Wanted

Repository metrics

Stars
 (108,860 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

🔎 Search Terms

is:issue Number toFixed

🕗 Version & Regression Information

  • This changed between versions ______ and _______
  • This changed in commit or PR _______
  • This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________
  • I was unable to test this on prior versions because _______

⏯ Playground Link

No response

💻 Code

// Your code here

🙁 Actual behavior

https://github.com/microsoft/TypeScript/blob/52395892e0c4ee8a22b4fa6190bad46d81e66651/src/lib/es5.d.ts#L550 https://github.com/microsoft/TypeScript/blob/52395892e0c4ee8a22b4fa6190bad46d81e66651/src/lib/es5.d.ts#L556 https://github.com/microsoft/TypeScript/blob/52395892e0c4ee8a22b4fa6190bad46d81e66651/src/lib/es5.d.ts#L562

🙂 Expected behavior

The right range is 0 to 100 for toFixed and toExponential, 1 to 100 for toPrecision.

Additional information about the issue

No response

Contributor guide

Research direction
Edit the lines in src/lib/es5.d.ts: line 550 (toFixed) change '0-20' to '0-100'; line 556 (toExponential) change '0-20' to '0-100'; line 562 (toPrecision) change '0-21' to '1-100'.
Tech stack
typescriptjavascript
Domain
documentation
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90