Microsoft/TypeScript

cloneNode should return sub type, not Node

Open

#283 opened on Jul 28, 2014

View on GitHubContributor guide
 (25 comments) (64 reactions) (0 assignees)TypeScript (13,395 forks)batch import
BugDomain: lib.d.tsHelp Wanted

Repository metrics

Stars
 (108,860 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

When I do someElement.cloneNode(), I want the returned element to be the same type as someElement, but right now it's returning type Node.

Contributor guide

Research direction
Examine the lib.dom.d.ts type definitions for Node.cloneNode and Element.cloneNode. Update the return type to match the actual behavior where cloneNode returns the same type as the original node.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75