code healthdeveloper efficiencygood first issuehelp wanted
Repository metrics
- Stars
- (1,460 stars)
- PR merge metrics
- (No merged PRs in 30d)
Description
ae51153db2e623e8b9fb3609de3a6ad976addd0a enabled ruff-check in pre-commit. I added a bunch of rules to "ignore" list but I think there are too many "ignore"s: https://github.com/Lightning-AI/lightning-thunder/blob/ae51153db2e623e8b9fb3609de3a6ad976addd0a/pyproject.toml#L153-L176.
- "E731", # Do not assign a lambda expression, use a def
- "E501", # todo: Line too long (235 > 120 characters
- "F841", # https://docs.astral.sh/ruff/rules/unused-variable/
- "F821", # https://docs.astral.sh/ruff/rules/undefined-name/
- "E402", # https://docs.astral.sh/ruff/rules/module-import-not-at-top-of-file/
- "F401", # https://docs.astral.sh/ruff/rules/unused-import/
- "F405", # https://docs.astral.sh/ruff/rules/undefined-local-with-import-star-usage/
- "E712", # https://docs.astral.sh/ruff/rules/true-false-comparison/
- "E711", # https://docs.astral.sh/ruff/rules/none-comparison/
- "E721", # https://docs.astral.sh/ruff/rules/type-comparison/
- "E722", # https://docs.astral.sh/ruff/rules/bare-except/
- "F403", # https://docs.astral.sh/ruff/rules/undefined-local-with-import-star/
- "F601", # https://docs.astral.sh/ruff/rules/multi-value-repeated-key-literal/
- "F822", # https://docs.astral.sh/ruff/rules/undefined-export/
- "F842", # https://docs.astral.sh/ruff/rules/unused-annotation/
- "F722", # https://docs.astral.sh/ruff/rules/forward-annotation-syntax-error/
- "E702", # https://docs.astral.sh/ruff/rules/multiple-statements-on-one-line-semicolon/
- "E741", # https://docs.astral.sh/ruff/rules/ambiguous-variable-name/
- "W293", # https://docs.astral.sh/ruff/rules/blank-line-with-whitespace/
- "F811", # https://docs.astral.sh/ruff/rules/redefined-while-unused/
- "W291", # https://docs.astral.sh/ruff/rules/trailing-whitespace/
cc @borda @mruberry