Lightning-AI/lightning-thunder

Error on reentrant jit invocation

Open

#1,222 opened on Sep 30, 2024

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Python (114 forks)github user discovery
enhancementgood first issueux

Repository metrics

Stars
 (1,460 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

...to provide a better error message. Most likely the easiest is to add something like

    if get_jit_ctx() is not None:
        raise NotImplementedError("Re-entrant jitting is not supported")

to the top of thunder.jit.thunder_general_jit and then write a test.

First step in #1126

cc @carmocca @borda

Contributor guide

Research direction
Implement the reentrant jit check in thunder.jit.thunder general jit as described in the issue, and add a corresponding test.
Tech stack
pythonpytorch
Domain
compilersbackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90