Lightning-AI/lightning-thunder

Make autocast a Transform

Open

#1,122 opened on Sep 7, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (114 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (1,460 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently autocast (transforms/autocast.py) is carried over from the old-style transforms on callable and invoked like

jit(autocast(fn))

it would be good to make this a AutocastTransform to be invoked as

jit(fn, transforms=[Autocast()])

for better composability.

This should be vaguely doable with the transforms e.g. as explained in Thunder Sessions Episode 7 plus the bsym mapping provided by the existing mechanism, so it might be a good first or second issue.

Contributor guide

Research direction
Study the existing autocast function and the Transform class hierarchy in lightning thunder, then implement AutocastTransform following the pattern shown in Thunder Sessions Episode 7.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75