KenEucker/biketag-vue

[BUG] Runner up BikeTag Posts are not being saved into the BikeDex for each game

Open

#190 opened on Nov 29, 2023

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)TypeScript (20 forks)auto 404
good first issuehelp wanted

Repository metrics

Stars
 (26 stars)
PR merge metrics
 (Avg merge 11d 6h) (1 merged PR in 30d)

Description

Describe the bug It appears that the images are being saved before being deleted from the Queue, but they are saved in a new post, not within the correct album.

To Reproduce Steps to reproduce the behavior:

  1. Create a new BikeTag Post
  2. Create another BikeTag Post
  3. Wait for the tag to be autoposted
  4. See that the queue is cleared and the found image for the losing BikeTag Post was saved, but the image is not saved in the BikeDex album for that game

Expected behavior The tags should end up in the BikeDex album for later use.

Additional context This is more than likely a fix in the biketag-api project, within the archiveTag method: https://github.com/KenEucker/biketag-api/blob/production/src/imgur/archiveTag.ts

Once we have this working we can begin to work on fixing the display of these images on Player profiles.

Contributor guide

Research direction
Inspect the `archiveTag` method in the biketag api repository (https://github.com/KenEucker/biketag api/blob/production/src/imgur/archiveTag.ts). Trace how images are saved to the BikeDex album and ensure they are stored in the correct album associated with the game.
Tech stack
typescript
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70