JuliaLang/julia

Add `haskey` for `Tuple`

Open

#35,516 opened on Apr 18, 2020

View on GitHubContributor guide
 (7 comments) (2 reactions) (0 assignees)Julia (5,773 forks)batch import
collectionsgood first issue

Repository metrics

Stars
 (48,709 stars)
PR merge metrics
 (Avg merge 20d 6h) (157 merged PRs in 30d)

Description

Currently haskey is defined for NamedTuple but not for Tuple. Would it make sense to also add this for tuples? After all, keys(::Tuple) is also defined.

Code would then probably look like this

    haskey(t::Tuple, key) = isdefined(t, key)

Related: https://github.com/JuliaLang/julia/issues/32898

Contributor guide

Research direction
Implement `haskey` for `Tuple` by adding a method that uses `isdefined` to check if the tuple has a given key. Look at existing `haskey` implementations for `NamedTuple` for reference.
Tech stack
None
Domain
api
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJulia
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90