JuliaGeometry/Meshes.jl

Label not supported with viz

Open

#551 opened on Aug 7, 2023

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Julia (98 forks)auto 404
featurehelp wantedviz

Repository metrics

Stars
 (460 stars)
PR merge metrics
 (PR metrics pending)

Description

Hello :)

Trying to add a label to geometryobject (polyarea in this cade) isn't supported with the viz function. It results in the following error:

ERROR: `legendelements` returned an empty list for content element of type MakieCore.Combined{Meshes.viz, Tuple{GeometrySet{2, Float64, PolyArea{2, Float64, Ring{2, Float64, CircularArrays.CircularVector{Point2, Vector{Point2}}}}}}}. That could mean that neither this object nor any possible child objects had a method for `legendelements` defined that returned a non-empty result.

I know it isn't supported from the documentation, but it's a seems like a useful feature I'd like to ask for :) Thanks in advance!

Contributor guide

Research direction
Investigate how `legendelements` is implemented for other geometry types in Meshes.jl and how Makie generates legend entries. Look at the `viz` function recipe and determine where to add a method for `legendelements` for the relevant geometry type (e.g., GeometrySet with PolyArea). Potentially follow patterns from existing implementations in Makie or other packages.
Tech stack
julia
Domain
data visualization
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JuliaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65