JoarHansson/space-images-app

Change faulty state logic

Open

#4 opened on Sep 3, 2024

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)JavaScript (2 forks)auto 404
buggood first issuehacktoberfesthelp wanted

Repository metrics

Stars
 (2 stars)
PR merge metrics
 (PR metrics pending)

Description

  • Faulty logic: setImgLiked(false); in Home.jsx:26 and Home.jsx:68.

    • The logic is faulty because if it assumes the image thats going to show up is not going to be "liked" already, which can indeed be the case.
    • Local storage is already used to save (Home.jsx) and view images (Likes.jsx), and could probably be used here too.
    • A good way to recreate the problem/test a solution is to choose an image by date in the DateInput, like it, choose another image, and then choose it again to see if it's liked.

Contributor guide

Research direction
Inspect the faulty logic in Home.jsx lines 26 and 68 and use localStorage to persist liked state instead of always setting it to false.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80