Jaovitosr/Chatbot

Quick import should work if DOI is included

Open

#10 opened on Sep 14, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees) (0 forks)auto 404
FirstTimeCodeContributionfetchergood first issue

Repository metrics

Stars
 (0 stars)
PR merge metrics
 (PR metrics pending)

Description

From jabref created by koppor: JabRef/jabref#9821

  1. Open "Import new entry from Id"
    image
  2. Paste https://www.scitepress.org/Link.aspx?doi=10.5220/0010404301780189
  3. Click on the arrow on the right to trigger the fetch.

Expected result: Entry found

Actual result: No entry found

One can find the entry when searching for 10.5220/0010404301780189

There needs to be implemented a heuristic at the CompositeIdFetcher. Before passing the DOI to the DOI parser, a) existence of ?doi= needs to be checked, b) if yes, that part removed. Then passed to DOI.parse

/src/main/java/org/jabref/logic/importer/CompositeIdFetcher.java#L23

        Optional<DOI> doi = DOI.parse(identifier);

Test-enabling: Heuristics as own method. This method needs to be tested. Method can be "package private".

With that being implemented, https://github.com/JabRef/jabref/issues/7575 can also be fixed (howto at https://github.com/JabRef/jabref/issues/7575#issuecomment-1529055712).

Contributor guide

Research direction
Implement a heuristic in CompositeIdFetcher to check for '?doi=' in the identifier and strip it before passing to DOI.parse. Write a test for the heuristic.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75