INRIA/spoon

Get rid of warnings in Spoon's build

Open

#4,924 opened on Sep 27, 2022

View on GitHubContributor guide
 (9 comments) (2 reactions) (0 assignees)Java (383 forks)github user discovery
good first issuerefactor

Repository metrics

Stars
 (1,933 stars)
PR merge metrics
 (Avg merge 19d 11h) (49 merged PRs in 30d)

Description

I think it's about time we clean up the compile output and actually start to care about warnings, or even better, treat warnings as errors and selectively suppress the ones that we don't care about.

I've been bothered by the warnings in the build output for a good while. All of the garbage warnings obscure "real" warnings, such as deprecations in libraries we depend upon.

I propose two things:

  1. We get rid of the current warnings.
  2. We treat warnings as errors so we can keep the build output clean, and actually act upon new warnings.

To get the warnings:

mvn clean compile

Contributor guide

Research direction
Inspect the Maven build configuration (pom.xml) and identify compiler warnings. Configure Maven to treat warnings as errors using <compilerArgs> or <maven compiler plugin> settings, and selectively suppress specific warnings with annotations or compiler options.
Tech stack
java
Domain
build systemdeveloper experience
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaMaven
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70