INRIA/spoon

refactor: move tests resources

Open

#2,137 opened on Jun 29, 2018

View on GitHubContributor guide
 (24 comments) (0 reactions) (0 assignees)Java (383 forks)github user discovery
discussiongood first issuetest

Repository metrics

Stars
 (1,933 stars)
PR merge metrics
 (Avg merge 19d 11h) (49 merged PRs in 30d)

Description

As pointed out in #2136 the tests directory is a bit messy, especially when you're not familiar with Spoon contribution. I would suggest to refactor it at least to have properly defined rules for the test resources.

We currently have test resources, in at least 3 different places:

  1. src/test/resources the standard directory
  2. src/test/java/X/testclasses in a subpackage, along with their test suite
  3. src/test/java/X in the same package of the test suite

So I suggest first to move the test resources from case 3 to put - at least - the resources in a subpackage testclasses. I don't think it's desirable to move all test resources in place 1, as I think we want to check that we can compile them.

WDYT?

Contributor guide

Research direction
Identify test resources in case 3, move them to a 'testclasses' subpackage, update references, and ensure compilation. Discuss structure with the community via the issue comments.
Tech stack
java
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65