GreenStepsChatt/greensteps

Show matcher should be scoped to the expected object

Open

#20 opened on Sep 21, 2017

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Ruby (30 forks)auto 404
help wantedready

Repository metrics

Stars
 (12 stars)
PR merge metrics
 (PR metrics pending)

Description

Right now, the show matcher ignores what is passed to expect. It just looks to see if the specified page object is anywhere on the page. When we expect one page object to be a child of another, it would be nice to be able to say something like

expect(dashboard).to show :deed_form

This example comes from user_logs_deed_spec.rb. Right now, we can only assert that both objects are on the page:

expect(page).to show :deed_form
expect(page).to show :dashboard

With the way things are now if we were to say expect(dashboard).to show :deed_form it would pass, even if the deed form wasn't a child of the dashboard but was elsewhere on the page.

Contributor guide

Research direction
Examine the show matcher implementation and modify it to check that the page object is a child of the expected object.
Tech stack
ruby
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RubyRSpec
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75