GoogleChromeLabs/quicklink

Do not prefetch links with `download` attribute

Closed

#181 opened on May 15, 2020

View on GitHubContributor guide
 (2 comments) (1 reaction) (0 assignees)JavaScript (425 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (11,263 stars)
PR merge metrics
 (Avg merge 47d 12h) (4 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe. Currently all links are prefetched including ones intended for downloadable assets. Since these links could point to large payloads (imagine multi megabyte PDFs or zip archives) that's quite a waste of bandwidth.

I'd argue excluding links which have the download attribute would be a sensible default.

Describe the solution you'd like

document.querySelectorAll('a:not([download])')

Thank you :)

Contributor guide

Research direction
Modify the query selector to exclude links with download attribute using `a:not([download])`.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptCSS selectors
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90