FuelLabs/fuel-tx

Improve next duplicate of iterator

Open

#148 opened on Jun 23, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (3 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (14 stars)
PR merge metrics
 (PR metrics pending)

Description

This code is created as tech-debt and is under optimized. The iterator to find a duplicate shouldn't enforce copy and shouldn't allocated into a sorted vec.

https://github.com/FuelLabs/fuel-tx/blob/8e9dde715701f4535c07c2538c5f8ba7a4754c0a/src/transaction/internals.rs#L9-L23

Contributor guide

Research direction
Look at the referenced code and find a way to find duplicates without copying and sorting the whole vector. Consider using HashSet or dedup after sorting in place.
Tech stack
rust
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40