Food-Static-Data/sd

upgrade our examples/tests

Open

#524 opened on Jun 14, 2019

View on GitHub
 (9 comments) (0 reactions) (0 assignees)JavaScript (11 forks)auto 404
enhancementgeneratorgood first issuehelp wanted

Repository metrics

Stars
 (9 stars)
PR merge metrics
 (PR metrics pending)

Description

So, we have a folder https://github.com/GroceriStar/sd/tree/master/tests/examples

And here are simple tests, aka non-empty https://github.com/GroceriStar/sd/blob/master/tests/testFilesCheck/exampleFiles.test.js

As you can see - we have a pretty similar code there. we should update it and instead of having copy-paste - create a function and just pass a variable into it

https://github.com/GroceriStar/sd/blob/master/tests/projects/GroceriStar/groceristar.test.js#L32-L42

Contributor guide

Research direction
Review the duplicated test code in tests/examples and refactor it into a shared utility function; then update the test files to use the new function.
Tech stack
javascript
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80