EdenEast/nightfox.nvim

bug: italic option not work

Open

#454 opened on Oct 14, 2024

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Lua (171 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,063 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Neovim version (nvim -v)

Vim 9.1.1707

Operating system/version

MacOS 15.0

Describe the bug

Comments not italic inside vim, but my terminal can render italic font.

Steps To Reproduce

  1. setup nightfox
  2. open vim

Expected Behavior

render italic correctly, and don't need source config twice.

Repro

lua << EOF
require('nightfox').setup({
    options = {
        styles = {
            comments = "italic",
            keywords = "bold",
            types = "italic,bold",
        }
    }
})

vim.command"colorscheme nightfox"
EOF

Contributor guide

Research direction
Inspect the theme's highlight definitions for comments, specifically the 'Comment' highlight group. Check if italic is correctly applied and if there are any overrides from other plugins or the terminal.
Tech stack
lua
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitNeovim
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70