Duzzuti/passwd-manager

[NTH] Ensure that CMakeLists.txt is following the best practices

Open

#28 opened on Jun 8, 2023

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C++ (4 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (9 stars)
PR merge metrics
 (PR metrics pending)

Description

Since this project is partially aimed at developers improving their C++ and CMake skills I create this issue. The issue should be constantly ongoing and if we realize that some of our practices in CMakeLists.txt are not ideal we should make a PR referencing it.

This is a nice source to learn about the modern best practices for CMake: https://cliutils.gitlab.io/modern-cmake/

  • Difficulty (1-10): 2

  • Location/Files: CMakeLists.txt

Contributor guide

Research direction
Read the modern CMake best practices guide at the provided link and compare with the current CMakeLists.txt to identify areas for improvement, then open a pull request with changes.
Tech stack
cpp
Domain
build system
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++CMake
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80