DioxusLabs/taffy

Add tests for negative margins

Open

#475 opened on May 1, 2023

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Rust (192 forks)github user discovery
good first issuetesting

Repository metrics

Stars
 (3,189 stars)
PR merge metrics
 (Avg merge 15h 41m) (25 merged PRs in 30d)

Description

What problem does this solve or what need does it fill?

CSS supports negative margins, and Taffy also support setting a negative value for a margin style. However Taffy currently doesn't have any tests for negative margins (and I suspect we don't lay them out correctly either, although we won't know until we have tests)

What solution would you like?

  • Add generated tests for negative margins (for flexbox, grid, and leaf layout modes)
  • Fix any bugs

Contributor guide

Research direction
Familiarize yourself with the test generation infrastructure in Taffy. Identify where existing margin tests are defined. Create generated tests for negative margins for flexbox, grid, and leaf layout modes. Run the tests and fix any layout bugs that are uncovered.
Tech stack
rust
Domain
frontend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60