CleverRaven/Cataclysm-DDA

Foraging should be a proficiency

Open

#78,148 opened on Nov 25, 2024

View on GitHub
 (0 comments) (9 reactions) (0 assignees)C++ (3,991 forks)batch import
<Suggestion / Discussion>Help Wanted[C++]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe.

We have a lot of proficiencies for all kinds of stuff, but foraging lacks one even though it would make perfect sense there.

Solution you would like.

A foraging proficiency. This one is probably easy but not trivial to add as it needs to touch C++ hardcoded stuff. It should affect how often you find seasonal entries but not forest trash and maybe also how fast the action is done, but the speed up should not be immense.

Maybe as a bonus it may also reduce how often you find poisonous things (FORAGE_POISON flag).

Describe alternatives you have considered.

No response

Additional context

No response

Contributor guide

Research direction
The implementation should involve modifying the C++ code that handles proficiencies. Existing proficiency definitions can be found in the source code. The foraging action code likely includes a check for proficiency to modify speed and yield, and the FORAGE POISON flag should be considered. No linked PRs or comments provide guidance, so examining similar proficiencies (e.g., cooking or survival) is recommended.
Tech stack
cpp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++ knowledgeunderstanding of game's proficiency system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55