ChartsOrg/Charts

Default colors should adapt to macOS Mojave dark mode

Open

#3,742 opened on Nov 11, 2018

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Swift (5,993 forks)batch import
help wanted

Repository metrics

Stars
 (28,013 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

What did you do?

Rendered a chart under dark mode in Mojave.

What did you expect to happen?

Labels, grids, etc, to show in white color.

What happened instead?

Labels, grids, etc, show in black.

Charts Environment

Charts version/Branch/Commit Number:master Xcode version:10.1 Swift version:4.2 Platform(s) running Charts:macOS macOS version running Xcode:10.14.1 Mojave

Contributor guide

Research direction
Investigate how default colors are defined in the Charts library and adapt them to macOS Mojave dark mode. Use NSAppearance (macOS) or UITraitCollection (iOS) to detect dark mode and set appropriate foreground colors for labels, grids, etc.
Tech stack
swiftios
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
XcodeSwift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60